Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue that fileSize is nil on iOS #11

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Fix issue that fileSize is nil on iOS #11

merged 1 commit into from
Jan 24, 2021

Conversation

sboh1214
Copy link
Collaborator

Hello!

There was a potential problem with initiating OLEFile.
There is no fileSize attribute, unlike macOS and Linux.

So, I changed to calculate data.count.

I wish 0.3.1 hotfix publish with this PR. (So I set the milestone.)
Thanks.

@sboh1214 sboh1214 added this to the 0.3.1 milestone Jan 24, 2021
@sboh1214 sboh1214 self-assigned this Jan 24, 2021
MaxDesiatov
MaxDesiatov approved these changes Jan 24, 2021
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit, thanks 👍

@sboh1214 sboh1214 merged commit 06ecb13 into main Jan 24, 2021
@sboh1214 sboh1214 deleted the fix-filewrapper branch January 24, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees

@sboh1214 sboh1214

Labels
None yet
Projects
None yet
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sboh1214 @MaxDesiatov