Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preconditions to DataStream, tweak seek API #3

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Sep 14, 2020

@sboh1214 giving you some warning on how the API is going to change, the only breaking change is seek argument is now Int, not UInt64. Also, totalBytes property is now available.

Any feedback very welcome. 🙂

@MaxDesiatov MaxDesiatov added enhancement New feature or request breaking change Change that breaks API compatibility labels Sep 14, 2020
@sboh1214
Copy link
Collaborator

Glad to see more obvious and convenient APIs! Thanks

@MaxDesiatov MaxDesiatov merged commit 761a179 into main Sep 15, 2020
@MaxDesiatov MaxDesiatov deleted the datastream-tweaks branch September 15, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Change that breaks API compatibility enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants