Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miniStream iteration bug, add HWP test #5

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Sep 16, 2020

The sector data truncation logic was checking the constant value passed to the oleStream function, instead of the incremented iteration index.

Resolves #1.

@sboh1214, thank you for uncovering this bug! Would you mind if I add blank.hwp to the OLEKit test suite?

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Sep 16, 2020
@sboh1214
Copy link
Collaborator

You're welcome! Feel free to use blank.hwp or any files of my public repo!
I'll soon add a license such as Apache!
Overall, thanks for fixing the bug so fast!

@MaxDesiatov MaxDesiatov merged commit 6a809b9 into main Sep 16, 2020
@MaxDesiatov MaxDesiatov deleted the ministream-iteration branch September 16, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] get wrong stream position while get "FileHeader" stream in ".hwp" file
2 participants