Skip to content

Commit

Permalink
Add missing CFBundleVersion, bump version to 0.3.1 (#74)
Browse files Browse the repository at this point in the history
Using carthage to either grab the latest prebuilt binary 0.3.0 or forcing carthage to build the latest XmlCoder results in the framework's plist missing a value for CFBundleVersion, which is required for AppStore Connect upload. Other plist keys are correctly filled in. I see it's using the $(CURRENT_PROJECT_VERSION) variable for CFBundleVersion.

> AppStore error: ERROR ITMS-90056: XMLCoder.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion

Resolves #72
  • Loading branch information
MaxDesiatov committed Feb 6, 2019
1 parent 675f692 commit bd22c20
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 6 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# 0.3.1 (February 6, 2019)

A bugfix release that adds missing `CFBundleVersion` in generated framework's
`Info.plist` ([#72](https://github.com/MaxDesiatov/XMLCoder/issues/72) reported by
[@stonedauwg](https://github.com/stonedauwg)).

## Changes

* Set `CURRENT_PROJECT_VERSION` in project file ([#74](https://github.com/MaxDesiatov/XMLCoder/pull/74), [@MaxDesiatov](https://github.com/MaxDesiatov))

# 0.3.0 (January 22, 2019)

A maintenance release focused on fixing bugs, improving error reporting and
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ target 'YourApp' do
use_frameworks!

# Pods for Test
pod 'XMLCoder', '~> 0.3.0'
pod 'XMLCoder', '~> 0.3.1'

end
```
Expand Down Expand Up @@ -101,7 +101,7 @@ $ brew install carthage
Inside of your `Cartfile`, add GitHub path to `XMLCoder`:

```ogdl
github "MaxDesiatov/XMLCoder" ~> 0.3.0
github "MaxDesiatov/XMLCoder" ~> 0.3.1
```

Then, run the following command to build the framework:
Expand All @@ -124,7 +124,7 @@ easy as adding it to the `dependencies` value of your `Package.swift`.

```swift
dependencies: [
.package(url: "https://github.com/MaxDesiatov/XMLCoder.git", from: "0.3.0")
.package(url: "https://github.com/MaxDesiatov/XMLCoder.git", from: "0.3.1")
]
```

Expand Down
6 changes: 5 additions & 1 deletion Sources/XMLCoder/Auxiliaries/Box/KeyedBox.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// KeyedBox.swift
// XMLCoderPackageDescription
// XMLCoder
//
// Created by Vincent Esche on 11/19/18.
//
Expand All @@ -12,6 +12,10 @@ struct KeyedStorage<Key: Hashable & Comparable, Value> {

fileprivate var buffer: Buffer = [:]

var isEmpty: Bool {
return buffer.isEmpty
}

var count: Int {
return buffer.count
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/XMLCoder/Decoder/XMLUnkeyedDecodingContainer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ struct XMLUnkeyedDecodingContainer: UnkeyedDecodingContainer {
if let type = type as? AnyArray.Type,
let keyedBox = container
.withShared({ $0[self.currentIndex] as? KeyedBox }),
keyedBox.attributes.count == 0,
keyedBox.attributes.isEmpty,
keyedBox.elements.count == 1,
let firstKey = keyedBox.elements.keys.first,
let unkeyedBox = keyedBox.elements[firstKey] {
Expand Down
2 changes: 1 addition & 1 deletion XMLCoder.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "XMLCoder"
s.version = "0.3.0"
s.version = "0.3.1"
s.summary = "XMLEncoder & XMLDecoder using the Codable protocol in Swift 4"
s.description = "XMLCoder allows Swift 4 Codable-conforming objects to be translated to and from XML"
s.homepage = "https://github.com/MaxDesiatov/XMLCoder"
Expand Down
2 changes: 2 additions & 0 deletions XMLCoder.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,7 @@
CLANG_ENABLE_OBJC_ARC = YES;
COMBINE_HIDPI_IMAGES = YES;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 0.3.1;
DEBUG_INFORMATION_FORMAT = dwarf;
DYLIB_INSTALL_NAME_BASE = "@rpath";
ENABLE_NS_ASSERTIONS = YES;
Expand Down Expand Up @@ -683,6 +684,7 @@
CLANG_ENABLE_OBJC_ARC = YES;
COMBINE_HIDPI_IMAGES = YES;
COPY_PHASE_STRIP = YES;
CURRENT_PROJECT_VERSION = 0.3.1;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DYLIB_INSTALL_NAME_BASE = "@rpath";
GCC_OPTIMIZATION_LEVEL = s;
Expand Down

0 comments on commit bd22c20

Please sign in to comment.