Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP / Proof of concept] Add Decoding support for enums with associated values #113

Closed
wants to merge 33 commits into from
Closed

[WIP / Proof of concept] Add Decoding support for enums with associated values #113

wants to merge 33 commits into from

Commits on Jul 12, 2019

  1. Add Decoding support for enums with associated values

    @jsbean
    jsbean committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    5c7d809 View commit details
    Browse the repository at this point in the history

  2. There should be no space before and one after any comma

    @jsbean
    jsbean committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    a9e9796 View commit details
    Browse the repository at this point in the history

  3. Lines should not have trailing whitespace

    @jsbean
    jsbean committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    870f9e8 View commit details
    Browse the repository at this point in the history

  4. Lines should not have trailing whitespace

    @jsbean
    jsbean committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    36f0507 View commit details
    Browse the repository at this point in the history

  5. Limit vertical whitespace to a single empty line

    @jsbean
    jsbean committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    280de28 View commit details
    Browse the repository at this point in the history

  6. Lines should not have trailing whitespace

    @jsbean
    jsbean committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    9ee2b90 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2019

  1. Relax elements.count constraint, fix test (kind of)

    @jsbean
    jsbean committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    6d6353d View commit details
    Browse the repository at this point in the history

  2. Destructure closure to help compiler

    @jsbean
    jsbean committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    09120a3 View commit details
    Browse the repository at this point in the history

  3. Initialize KeyedStorage explicitly with empty attributes

    @jsbean
    jsbean committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    ba4c18e View commit details
    Browse the repository at this point in the history

  4. Run swiftformat

    @bwetherfield
    bwetherfield committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    b70ef0a View commit details
    Browse the repository at this point in the history

  5. Remove prints

    @bwetherfield
    bwetherfield committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    d19fd94 View commit details
    Browse the repository at this point in the history

  6. Remove xcscheme

    @bwetherfield
    bwetherfield committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    cc4b7cc View commit details
    Browse the repository at this point in the history

  7. Run swiftformat

    @bwetherfield @jsbean
    bwetherfield authored and jsbean committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    999397c View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'jsbean/bean/decoding-enums' into wether… 

    …field/decoding-enums
    @bwetherfield
    bwetherfield committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    fe7893c View commit details
    Browse the repository at this point in the history

  9. Add concrete decoding tests

    @bwetherfield
    bwetherfield committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    717f56c View commit details
    Browse the repository at this point in the history

  10. Fix formatting

    @bwetherfield
    bwetherfield committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    315583b View commit details
    Browse the repository at this point in the history

  11. Remove type(of:) definitions

    @bwetherfield
    bwetherfield committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    0e459b1 View commit details
    Browse the repository at this point in the history

  12. Add concrete decoding nested keyed/unkeyed tests (1 of 4 failing) (#6)

    @bwetherfield @jsbean
    bwetherfield authored and jsbean committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    f243699 View commit details
    Browse the repository at this point in the history

  13. Build out pathways to sniff out enum amongst nested arrays

    @jsbean
    jsbean committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    b3648dc View commit details
    Browse the repository at this point in the history

  14. Fix nested arrays test

    @jsbean
    jsbean committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    a6b67b5 View commit details
    Browse the repository at this point in the history

  15. Whitespace

    @jsbean
    jsbean committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    ce1fd9a View commit details
    Browse the repository at this point in the history

  16. Remove comment about failure

    @jsbean
    jsbean committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    8f7f330 View commit details
    Browse the repository at this point in the history

  17. Add perf baselines

    @jsbean
    jsbean committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    f1a432a View commit details
    Browse the repository at this point in the history

  18. Add basic enum round trip test

    @jsbean
    jsbean committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    03439ff View commit details
    Browse the repository at this point in the history

  19. Add failing Array of enums round trip test

    @jsbean
    jsbean committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    53b2256 View commit details
    Browse the repository at this point in the history

  20. Merge remote-tracking branch 'jsbean/bean/decoding-enums' into wether… 

    …field/decoding-enums
    @bwetherfield
    bwetherfield committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    d26a698 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2019

  1. Fix roundtrip test

    @bwetherfield
    bwetherfield committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    f0e1d04 View commit details
    Browse the repository at this point in the history

  2. Fix testIntOrStringArrayRoundTrip()

    @bwetherfield @jsbean
    bwetherfield authored and jsbean committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    70d82fe View commit details
    Browse the repository at this point in the history

  3. Add pattern matching to encoding step

    @bwetherfield
    bwetherfield committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    e57b271 View commit details
    Browse the repository at this point in the history

  4. Improve patternmatching syntax

    @bwetherfield
    bwetherfield committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    85dcf97 View commit details
    Browse the repository at this point in the history

  5. Fix formatting

    @bwetherfield
    bwetherfield committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    a9e4a27 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'bean/decoding-enums' into fix-just-encoding

    @bwetherfield
    bwetherfield committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    d81bce7 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #9 from bwetherfield/fix-just-encoding

    @jsbean
    jsbean committed Jul 14, 2019
    Configuration menu
    Copy the full SHA
    a1f3af0 View commit details
    Browse the repository at this point in the history