Adds .noEmptyElements option to OutputFormatting
#264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opts out of empty element shorthand.
Joannis
reviewed
May 2, 2023
|
I think that OutputFormatting is fine. Thanks for the contribution! I think I can merge this if the tests succeed |
|
I know that the one test that failed in your previous commit is not your fault. |
|
Tagged as 0.17.0 |
|
Thank you, @Joannis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opts out of empty element shorthand.
I'm using XMLCoder to generate XML from my Swift data models for use in another system that doesn't handle the empty-elements, so I've added this option to allow generating XML that it can ingest. Not sure if
OutputFormattingis the right place for this.