Skip to content

Commit

Permalink
addressed PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
miladz68 committed Jan 15, 2024
1 parent 6547cf2 commit 409ab5f
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 24 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,4 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
generate_release_notes: true
files: |
/home/runner/release-build/relayer-linux-amd64
/home/runner/release-build/relayer-darwin-amd64
/home/runner/release-build/relayer-darwin-arm64
/home/runner/release-build/coreumbridge_xrpl.wasm
/home/runner/release-build/checksums.txt
/home/runner/release-build/*
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ build-relayer:
.PHONY: release-relayer
release-relayer:
@$(MAKE) build-relayer-in-docker GOOS=linux GOARCH=amd64 BINARY_NAME=relayer-linux-amd64
@$(MAKE) build-relayer-in-docker GOOS=linux GOARCH=arm64 BINARY_NAME=relayer-linux-arm64
@$(MAKE) build-relayer-in-docker GOOS=darwin GOARCH=amd64 BINARY_NAME=relayer-darwin-amd64
@$(MAKE) build-relayer-in-docker GOOS=darwin GOARCH=arm64 BINARY_NAME=relayer-darwin-arm64

Expand Down
39 changes: 21 additions & 18 deletions relayer/cmd/cli/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,27 @@ $ set-xrpl-trust-set 1e80 %s %s --key-name sender
return cmd
}

// VersionCommand returns a CLI command to interactively print the application binary version information.
func VersionCommand() *cobra.Command {
return &cobra.Command{
Use: "version",
Short: "Print the application binary version information",
RunE: func(cmd *cobra.Command, _ []string) error {
logger, err := getConsoleLogger()
if err != nil {
return err
}
logger.Info(
cmd.Context(),
"Version Info",
zap.String("Git Tag", runner.VersionTag),
zap.String("Git Commit", runner.GitCommit),
)
return nil
},
}
}

func readAddressFromKeyNameFlag(cmd *cobra.Command, clientCtx client.Context) (sdk.AccAddress, error) {
keyName, err := cmd.Flags().GetString(FlagKeyName)
if err != nil {
Expand Down Expand Up @@ -891,21 +912,3 @@ func getConsoleLogger() (*logger.ZapLogger, error) {

return zapLogger, nil
}

// VersionCommand returns a CLI command to interactively print the application binary version information.
func VersionCommand() *cobra.Command {
return &cobra.Command{
Use: "version",
Short: "Print the application binary version information",
RunE: func(cmd *cobra.Command, _ []string) error {
fmt.Printf(`
Git Tag: %s,
Git Commit: %s,
`,
runner.VersionTag,
runner.GitCommit,
)
return nil
},
}
}

0 comments on commit 409ab5f

Please sign in to comment.