Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relayer version metric + dashboard. #205

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Apr 11, 2024

Description

Add relayer version metric + dashboard.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@dzmitryhil dzmitryhil requested a review from a team as a code owner April 11, 2024 09:49
@dzmitryhil dzmitryhil requested review from masihyeganeh, miladz68, ysv and wojtek-coreum and removed request for a team April 11, 2024 09:49
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @wojtek-coreum)


infra/composer/grafana/dashboards/relayer.json line 1721 at r1 (raw file):

          "selected": true,
          "text": [
            "devcore1l9d79mawwv2lhel5eh9z0mp0fpff7pz7grm5tm"

are these hardcoded values expected here ?

I think Artem will just copy these

Copy link
Contributor Author

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, @wojtek-coreum, and @ysv)


infra/composer/grafana/dashboards/relayer.json line 1721 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

are these hardcoded values expected here ?

I think Artem will just copy these

Removed.

ysv
ysv previously approved these changes Apr 11, 2024
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh, @miladz68, and @wojtek-coreum)

miladz68
miladz68 previously approved these changes Apr 15, 2024
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @wojtek-coreum)

# Conflicts:
#	relayer/coreum/contract.go
#	relayer/metrics/registry.go
@dzmitryhil dzmitryhil dismissed stale reviews from miladz68 and ysv via 029473f April 17, 2024 11:22
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @wojtek-coreum)

@dzmitryhil dzmitryhil requested a review from ysv April 17, 2024 12:00
@dzmitryhil dzmitryhil merged commit e384e9c into master Apr 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants