Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relayer init CLI command. #56

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Add relayer init CLI command. #56

merged 1 commit into from
Dec 8, 2023

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Dec 1, 2023

Description

Add relayer init CLI command.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@dzmitryhil dzmitryhil requested a review from a team as a code owner December 1, 2023 08:58
@dzmitryhil dzmitryhil requested review from miladz68, ysv and wojtek-coreum and removed request for a team December 1, 2023 08:58
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)


relayer/cmd/cli/cli.go line 58 at r1 (raw file):

// StartCmd returns the start cmd.
func StartCmd() *cobra.Command {

this Cmd is not implementation but just an example of how we can pass keyring password ?


relayer/cmd/cli/cli.go line 141 at r1 (raw file):

func addKeyringFlags(cmd *cobra.Command) {
	cmd.PersistentFlags().String(flags.FlagKeyringBackend, flags.DefaultKeyringBackend, "Select keyring's backend (os|file|kwallet|pass|test)")
	cmd.PersistentFlags().String(flags.FlagKeyringDir, path.Join(DefaultHomeDir, "keys"), "The client Keyring directory; if omitted, the default 'home' directory will be used")

--home passed to this command or HOME for the user ?

Copy link
Contributor Author

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @wojtek-coreum, and @ysv)


relayer/cmd/cli/cli.go line 58 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

this Cmd is not implementation but just an example of how we can pass keyring password ?

For now - yes. I updated the logger in the CLI in general that's why updated it here as well.


relayer/cmd/cli/cli.go line 141 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

--home passed to this command or HOME for the user ?

The if you provided --home than home path you provided, if not $HOME.

Copy link
Contributor Author

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @wojtek-coreum, and @ysv)


relayer/cmd/cli/cli.go line 141 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

The if you provided --home than home path you provided, if not $HOME.

Default path will be: $HOME/.coreumbridge/keys or provided path my the flag.

Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @wojtek-coreum)

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

@dzmitryhil dzmitryhil merged commit 6b5f004 into master Dec 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants