-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relayer init
CLI command.
#56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)
relayer/cmd/cli/cli.go
line 58 at r1 (raw file):
// StartCmd returns the start cmd. func StartCmd() *cobra.Command {
this Cmd is not implementation but just an example of how we can pass keyring password ?
relayer/cmd/cli/cli.go
line 141 at r1 (raw file):
func addKeyringFlags(cmd *cobra.Command) { cmd.PersistentFlags().String(flags.FlagKeyringBackend, flags.DefaultKeyringBackend, "Select keyring's backend (os|file|kwallet|pass|test)") cmd.PersistentFlags().String(flags.FlagKeyringDir, path.Join(DefaultHomeDir, "keys"), "The client Keyring directory; if omitted, the default 'home' directory will be used")
--home
passed to this command or HOME for the user ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @wojtek-coreum, and @ysv)
relayer/cmd/cli/cli.go
line 58 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
this Cmd is not implementation but just an example of how we can pass keyring password ?
For now - yes. I updated the logger in the CLI in general that's why updated it here as well.
relayer/cmd/cli/cli.go
line 141 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
--home
passed to this command or HOME for the user ?
The if you provided --home than home path you provided, if not $HOME.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @wojtek-coreum, and @ysv)
relayer/cmd/cli/cli.go
line 141 at r1 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
The if you provided --home than home path you provided, if not $HOME.
Default path will be: $HOME/.coreumbridge/keys or provided path my the flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @wojtek-coreum)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)
Description
Add relayer
init
CLI command.Reviewers checklist:
Authors checklist
This change is