-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove building code moved to other repositories #361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 31 files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 31 of 31 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68 and @wojtek-coreum)
.github/workflows/ci.yml
line 19 at r2 (raw file):
"lint", "test", "integration tests coreum-upgrade & coreum-modules",
so now we don't run all the integration tests for all components in crust ?
build/index.go
line 20 at r2 (raw file):
var Commands = map[string]build.CommandFunc{ "build": buildBinaries, "build/bdjuno": bdjuno.Build,
I thought that crust will still be able to do this but by proxying it to components
Maybe this change is not for this PR but lets discuss to make sure we are on the same page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68 and @ysv)
.github/workflows/ci.yml
line 19 at r2 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
so now we don't run all the integration tests for all components in crust ?
no, because changes in crust don't affect local repos until new version is imported by that repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68)
Description
Reviewers checklist:
Authors checklist
This change is