Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove building code moved to other repositories #361

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Remove building code moved to other repositories #361

merged 5 commits into from
Feb 22, 2024

Conversation

wojtek-coreum
Copy link
Collaborator

@wojtek-coreum wojtek-coreum commented Feb 22, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@wojtek-coreum wojtek-coreum requested a review from a team as a code owner February 22, 2024 07:47
@wojtek-coreum wojtek-coreum requested review from dzmitryhil, miladz68 and ysv and removed request for a team February 22, 2024 07:47
dzmitryhil
dzmitryhil previously approved these changes Feb 22, 2024
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 31 files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 31 of 31 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68 and @wojtek-coreum)


.github/workflows/ci.yml line 19 at r2 (raw file):

          "lint",
          "test",
          "integration tests coreum-upgrade & coreum-modules",

so now we don't run all the integration tests for all components in crust ?


build/index.go line 20 at r2 (raw file):

var Commands = map[string]build.CommandFunc{
	"build":                                  buildBinaries,
	"build/bdjuno":                           bdjuno.Build,

I thought that crust will still be able to do this but by proxying it to components

Maybe this change is not for this PR but lets discuss to make sure we are on the same page

Copy link
Collaborator Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68 and @ysv)


.github/workflows/ci.yml line 19 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

so now we don't run all the integration tests for all components in crust ?

no, because changes in crust don't affect local repos until new version is imported by that repo

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

@ysv ysv merged commit ef5a474 into master Feb 22, 2024
3 checks passed
@ysv ysv deleted the wojtek/build branch February 22, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants