Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify test groups #365

Merged
merged 10 commits into from
Mar 21, 2024
Merged

Simplify test groups #365

merged 10 commits into from
Mar 21, 2024

Conversation

wojtek-coreum
Copy link
Collaborator

@wojtek-coreum wojtek-coreum commented Feb 23, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@wojtek-coreum wojtek-coreum requested a review from a team as a code owner February 23, 2024 09:28
@wojtek-coreum wojtek-coreum requested review from dzmitryhil, miladz68 and ysv and removed request for a team February 23, 2024 09:28
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)


infra/testing/run.go line 32 at r1 (raw file):

	TestGroupCoreumIBC                 = "coreum-ibc"
	TestGroupFaucet                    = "faucet"
	TestGroupCoreumBridgeXRPLContract  = "coreumbridge-xrpl-contract"

IMO we don't need the test goups for the bridge at all. The bridge runs all tests himself, so no need for crust to build and run it.

Copy link
Collaborator Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @ysv)


infra/testing/run.go line 32 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

IMO we don't need the test goups for the bridge at all. The bridge runs all tests himself, so no need for crust to build and run it.

This will be the new command to run bridge tests:

crust znet --test-groups=coreumbridge-xrpl-contract

Copy link
Collaborator Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @ysv)


infra/testing/run.go line 32 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

This will be the new command to run bridge tests:

crust znet --test-groups=coreumbridge-xrpl-contract

This task is about bringing our standard building system to bridge: https://app.clickup.com/t/8687dy4q2

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)


infra/testing/run.go line 32 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

This task is about bringing our standard building system to bridge: https://app.clickup.com/t/8687dy4q2

IMO we should stop doint that here as well :-)
That's the repo specific thing

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @ysv)


infra/testing/run.go line 32 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

IMO we should stop doint that here as well :-)
That's the repo specific thing

I agree we should not run bridge tests with znet

@ysv ysv requested a review from dzmitryhil February 26, 2024 11:48
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil)


infra/testing/run.go line 32 at r1 (raw file):

Previously, miladz68 (milad) wrote…

I agree we should not run bridge tests with znet

also discussed this on call and agreed to not run these tests with znet

miladz68
miladz68 previously approved these changes Mar 11, 2024
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @wojtek-coreum)

@wojtek-coreum wojtek-coreum changed the title Simplify test groups and add ones for XRPL bridge Simplify test groups Mar 12, 2024
Copy link
Collaborator Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @ysv)


infra/testing/run.go line 32 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

also discussed this on call and agreed to not run these tests with znet

Done.

@ysv ysv requested a review from miladz68 March 13, 2024 08:40
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @miladz68)

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

@wojtek-coreum wojtek-coreum merged commit 52b674d into master Mar 21, 2024
3 checks passed
@wojtek-coreum wojtek-coreum deleted the wojtek/test-paths branch March 21, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants