-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify test groups #365
Simplify test groups #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)
infra/testing/run.go
line 32 at r1 (raw file):
TestGroupCoreumIBC = "coreum-ibc" TestGroupFaucet = "faucet" TestGroupCoreumBridgeXRPLContract = "coreumbridge-xrpl-contract"
IMO we don't need the test goups for the bridge at all. The bridge runs all tests himself, so no need for crust to build and run it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @ysv)
infra/testing/run.go
line 32 at r1 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
IMO we don't need the test goups for the bridge at all. The bridge runs all tests himself, so no need for crust to build and run it.
This will be the new command to run bridge tests:
crust znet --test-groups=coreumbridge-xrpl-contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @ysv)
infra/testing/run.go
line 32 at r1 (raw file):
Previously, wojtek-coreum (Wojtek) wrote…
This will be the new command to run bridge tests:
crust znet --test-groups=coreumbridge-xrpl-contract
This task is about bringing our standard building system to bridge: https://app.clickup.com/t/8687dy4q2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)
infra/testing/run.go
line 32 at r1 (raw file):
Previously, wojtek-coreum (Wojtek) wrote…
This task is about bringing our standard building system to bridge: https://app.clickup.com/t/8687dy4q2
IMO we should stop doint that here as well :-)
That's the repo specific thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @ysv)
infra/testing/run.go
line 32 at r1 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
IMO we should stop doint that here as well :-)
That's the repo specific thing
I agree we should not run bridge tests with znet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil)
infra/testing/run.go
line 32 at r1 (raw file):
Previously, miladz68 (milad) wrote…
I agree we should not run bridge tests with znet
also discussed this on call and agreed to not run these tests with znet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @wojtek-coreum)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @ysv)
infra/testing/run.go
line 32 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
also discussed this on call and agreed to not run these tests with znet
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @miladz68)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)
Description
Reviewers checklist:
Authors checklist
This change is