Revert to passing BinOutputPath as standalone field in go build

[wojtek-coreum]

Description

The original way was there for purpose. If cmd.Dir is not set, go.mod for the main module is used by the build command instead of the one defined in the submodule.

Reviewers checklist:

• Try to write more meaningful comments with clear actions to be taken.
• Nit-picking should be unblocking. Focus on core issues.

Authors checklist

• Provide a concise and meaningful description
• Review the code yourself first, before making the PR.
• Annotate your PR in places that require explanation.
• Think and try to split the PR to smaller PR if it is big.

---

This change is 

[ysv]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @wojtek-coreum)

---

build/golang/go.go line 99 at r1 (raw file):

	cmd := exec.Command(tools.Path("bin/go", tools.TargetPlatformLocal), args...)
	cmd.Dir = config.PackagePath

this doesn't work properly, that is why I changed it

[ysv]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @wojtek-coreum)

---

build/golang/go.go line 99 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

this doesn't work properly, that is why I changed it

why do we need this ?
What are the benefits of this approach ?

[wojtek-coreum]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @ysv)

---

build/golang/go.go line 99 at r1 (raw file):

this doesn't work properly, that is why I changed it

What didn't work?

What are the benefits of this approach ?

This is how go build works. To use the correct go.mod you need to be in the right directory.
Try to run bin/bdjuno-builder build/me in the bdjuno repo.

[ysv]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @wojtek-coreum)

---

build/golang/go.go line 99 at r1 (raw file):

What didn't work?

Test it in coreum repo with native build & in docker.
As far as I remember when building in docker it didn't work properly. Since it changes directory, so resulting binary was mounted to build/cmd/bin/.cache/cored/docker.linux.arm64/bin/cored instead of bin/.cache/cored/docker.linux.arm64/bin/cored. Smth like this

[wojtek-coreum]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @ysv)

---

build/golang/go.go line 99 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

What didn't work?

Test it in coreum repo with native build & in docker.
As far as I remember when building in docker it didn't work properly. Since it changes directory, so resulting binary was mounted to build/cmd/bin/.cache/cored/docker.linux.arm64/bin/cored instead of bin/.cache/cored/docker.linux.arm64/bin/cored. Smth like this

I see path is correct

[miladz68]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, and @ysv)

[dzmitryhil]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @ysv)

[ysv]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @wojtek-coreum)

---

build/golang/go.go line 99 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

I see path is correct

workDir = "/build/cmd"

-o = "bin/.cache/..."

check:
go build -o="bin/.cache"

[ysv]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @wojtek-coreum)

---

build/golang/go.go line 99 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

workDir = "/build/cmd"

-o = "bin/.cache/..."

check:
go build -o="bin/.cache"

Discussed issue on call

[wojtek-coreum]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @ysv)

---

build/golang/go.go line 99 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

Discussed issue on call

Done.

[dzmitryhil]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, and @ysv)

[ysv]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @miladz68)