Adding trace statement

CorfuDB · Dec 11, 2017 · 4876643 · 4876643
1 parent bcca6e2
commit 4876643
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 3 deletions.
diff --git a/generator/src/main/resources/logback-test.xml b/generator/src/main/resources/logback-test.xml
@@ -19,6 +19,13 @@
             <pattern>%d{yyyy-MM-dd_HH:mm:ss.SSS}, [%thread], %msg %n</pattern>
         </encoder>
     </appender>
+    <appender name="TRACER" class="ch.qos.logback.core.FileAppender">
+        <file>${user.home}/tracing.log</file>
+        <append>false</append>
+        <encoder>
+            <pattern>%d{HH:mm:ss.SSS} [%thread], %msg %n</pattern>
+        </encoder>
+    </appender>
 
     <!-- Control logging levels for individual components here. -->
     <logger name="org.corfudb.runtime.object" level="TRACE"/>
@@ -34,6 +41,11 @@
         <appender-ref ref="CORRECTNESS"/>
     </logger>
 
+    <!-- Tracing Logger: set level to TRACE/OFF to turn tracer on/off -->
+    <logger name="tracer" level="TRACE" additivity="false">
+        <appender-ref ref="TRACER"/>
+    </logger>
+
     <root level="TRACE">
         <!--<appender-ref ref="FILE" />-->
         <!--<appender-ref ref="STDOUT" />-->

diff --git a/runtime/src/main/java/org/corfudb/runtime/view/ObjectsView.java b/runtime/src/main/java/org/corfudb/runtime/view/ObjectsView.java
@@ -1,7 +1,5 @@
 package org.corfudb.runtime.view;
 
-import com.sun.xml.internal.bind.v2.TODO;
-
 import java.util.Arrays;
 import java.util.Map;
 import java.util.UUID;
@@ -28,13 +26,16 @@
 import org.corfudb.runtime.object.transactions.TransactionalContext;
 import org.corfudb.runtime.view.stream.IStreamView;
 import org.corfudb.util.serializer.Serializers;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * A view of the objects inside a Corfu instance.
  * Created by mwei on 1/7/16.
  */
 @Slf4j
 public class ObjectsView extends AbstractView {
+    public static final Logger tracerLog = LoggerFactory.getLogger("tracer");
 
     /**
      * The Transaction stream is used to log/write successful transactions from different clients.
@@ -118,6 +119,8 @@ public void TXBegin() {
             log.trace("Inheriting parent's transaction type {}", type);
         }
 
+        tracerLog.error("TXBegin | Type = {}", type);
+
         TXBuild()
                 .setType(type)
                 .begin();
@@ -145,6 +148,7 @@ public void TXAbort() {
         } else {
             TxResolutionInfo txInfo = new TxResolutionInfo(
                     context.getTransactionID(), context.getSnapshotTimestamp());
+            tracerLog.error("TXAbort | TXid = {}", txInfo.getTXid());
             context.abortTransaction(new TransactionAbortedException(
                     txInfo, null, AbortCause.USER, context));
             TransactionalContext.removeContext();
@@ -181,6 +185,7 @@ public long TXEnd()
             log.trace("TXCommit[{}] time={} ms",
                     context, totalTime);
             try {
+                tracerLog.error("TXCommit | TXid = {}", context.getTransactionID());
                 return TransactionalContext.getCurrentContext().commitTransaction();
             } catch (TransactionAbortedException e) {
                 log.warn("TXCommit[{}] Exception {}", context, e);

diff --git a/test/src/test/resources/logback-test.xml b/test/src/test/resources/logback-test.xml
@@ -26,6 +26,13 @@
             <pattern>%d %highlight(%-5level) - %msg%n %ex{short}</pattern>
         </encoder>
     </appender>
+    <appender name="TRACER" class="ch.qos.logback.core.FileAppender">
+        <file>${user.home}/tracing.log</file>
+        <append>false</append>
+        <encoder>
+            <pattern>%d{HH:mm:ss.SSS} [%thread], %msg %n</pattern>
+        </encoder>
+    </appender>
 
     <!-- Control logging levels for individual components here. -->
     <logger name="org.corfudb.runtime.object" level="TRACE"/>
@@ -35,14 +42,20 @@
     <logger name="io.netty.util.internal" level="INFO"/>
     <logger name="io.netty.buffer" level="INFO"/>
 
+    <!-- Metrics Logger -->
     <logger name="org.corfudb.metricsdata" level="INFO">
         <!--<appender-ref ref="MetricsRollingFile" />-->
     </logger>
 
+    <!-- Tracing Logger: set level to TRACE/OFF to turn tracer on/off -->
+    <logger name="tracer" level="TRACE" additivity="false">
+        <appender-ref ref="TRACER"/>
+    </logger>
 
     <root level="INFO">
         <!--<appender-ref ref="FILE" />-->
-        <!--<appender-ref ref="STDOUT" />-->
         <!--<appender-ref ref="MetricsRollingFile" />-->
+        <!--<appender-ref ref="STDOUT" />-->
+        <!--<appender-ref ref="TRACER" />-->
     </root>
 </configuration>