Skip to content

Commit

Permalink
Set stream batch size to 1 if readCache is disabled (#3728)
Browse files Browse the repository at this point in the history
Stream batch read only works when readCache is enabled.
If readCache is disabled, stream batch read introduces
wasteful reads because the results can't be cached.
  • Loading branch information
Lujie1996 committed Jul 26, 2023
1 parent 65bd983 commit 85d9ea1
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ public AddressSpaceView(@Nonnull final CorfuRuntime runtime) {

if (maxCacheEntries == 0) {
log.warn("Since AddressSpaceView readCache size is 0, " +
"overriding CorfuRuntime bulkReadSize and checkpointReadBatchSize to 1.");
"overriding CorfuRuntime streamBatchSize and checkpointReadBatchSize to 1.");
runtime.getParameters().setStreamBatchSize(1);
runtime.getParameters().setCheckpointReadBatchSize(1);
}

Expand Down

0 comments on commit 85d9ea1

Please sign in to comment.