New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support EPoll/KQueue #1064
Support EPoll/KQueue #1064
Conversation
Changes Unknown when pulling c42bc87 on EPoll into ** on master**. |
Codecov Report
@@ Coverage Diff @@
## master #1064 +/- ##
=========================================
Coverage ? 66.85%
=========================================
Files ? 225
Lines ? 10259
Branches ? 1019
=========================================
Hits ? 6859
Misses ? 3007
Partials ? 393
Continue to review full report at Codecov.
|
Results automatically generated by CorfuDB Benchmark Framework to assess the performance of this pull request for commit 1848e77. *** 0.0% transaction FAILURE rate for NonConflictingTx+Scan workload, 1 threads, Disk mode An interactive dashboard with Pull Request Performance Metrics for ALL cluster types and numbers of threads in run, is available at: |
@@ -144,7 +144,7 @@ | |||
<dependency> | |||
<groupId>io.netty</groupId> | |||
<artifactId>netty-all</artifactId> <!-- Use 'netty-all' for 4.0 or above --> | |||
<version>4.1.10.Final</version> | |||
<version>4.1.18.Final</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this is ok. It is a z change so should be fine but I am not sure.
@medhavidhawan should we change the default to NIO? Or should we keep it auto? |
I think we should keep the default to NIO. We can then test auto separately. |
Results automatically generated by CorfuDB Benchmark Framework to assess the performance of this pull request for commit 328d59c. *** 0.0% transaction FAILURE rate for NonConflictingTx+Scan workload, 1 threads, Disk mode An interactive dashboard with Pull Request Performance Metrics for ALL cluster types and numbers of threads in run, is available at: |
Results automatically generated by CorfuDB Benchmark Framework to assess the performance of this pull request for commit 5a55bab. *** 0.0% transaction FAILURE rate for NonConflictingTx+Scan workload, 1 threads, Disk mode An interactive dashboard with Pull Request Performance Metrics for ALL cluster types and numbers of threads in run, is available at: |
Overview
Description: This PR builds on top of #1061 to support Epoll/Kqueue server channel types.
Why should this be merged: This relatively simple addition on top of #1061 allows the use of native Netty transports, which should be more performant than the default NIO channel type. In addition, this change paves the way to use the built-in Local channel type, which will allow us to use Netty for all tests.
Checklist (Definition of Done):