Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack trace print during TlsUtilsTest #1067

Merged
merged 2 commits into from Dec 12, 2017
Merged

Conversation

no2chem
Copy link
Member

@no2chem no2chem commented Dec 12, 2017

Overview

Description: This PR fixes an issue where TlsUtilsTest prints stack traces even though the tests pass.

Why should this be merged: Tests should not print stack traces - this PR resolves the issue with the test.

Related issue(s) (if applicable): #1063

Checklist (Definition of Done):

  • There are no TODOs left in the code
  • Coding conventions (e.g. for logging, unit tests) have been followed
  • Change is covered by automated tests
  • Public API has Javadoc

@no2chem no2chem added the bug label Dec 12, 2017
@no2chem no2chem added this to the 0.2.0 milestone Dec 12, 2017
@no2chem no2chem self-assigned this Dec 12, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5f7b71a on TlsUtilsStacktrace into ** on master**.

@corfudb-performance
Copy link
Collaborator

Results automatically generated by CorfuDB Benchmark Framework to assess the performance of this pull request for commit 5f7b71a.

*** 0.0% transaction FAILURE rate for NonConflictingTx+Scan workload, 1 threads, Disk mode
*** 0.0% transaction FAILURE rate for NonConflictingTx+Scan workload, 5 threads, Disk mode
*** 0.0% transaction FAILURE rate for NonConflictingTx+Scan workload, 10 threads, Disk mode
*** 0.0% transaction FAILURE rate for NonConflictingTx workload, 1 threads, Disk mode
*** 0.0% transaction FAILURE rate for NonConflictingTx workload, 5 threads, Disk mode
*** 0.0% transaction FAILURE rate for NonConflictingTx workload, 10 threads, Disk mode

An interactive dashboard with Pull Request Performance Metrics for ALL cluster types and numbers of threads in run, is available at:
Pull Request #1067 Graphs

@codecov
Copy link

codecov bot commented Dec 12, 2017

Codecov Report

Merging #1067 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
+ Coverage   66.63%   66.66%   +0.03%     
==========================================
  Files         201      201              
  Lines        9593     9593              
  Branches      969      969              
==========================================
+ Hits         6392     6395       +3     
+ Misses       2829     2825       -4     
- Partials      372      373       +1
Impacted Files Coverage Δ
.../infrastructure/management/PeriodicPollPolicy.java 89.01% <0%> (-3.3%) ⬇️
...va/org/corfudb/protocols/wireprotocol/LogData.java 84.16% <0%> (-0.84%) ⬇️
...main/java/org/corfudb/runtime/view/LayoutView.java 84.84% <0%> (ø) ⬆️
.../org/corfudb/runtime/object/CorfuCompileProxy.java 61.84% <0%> (+0.57%) ⬆️
...rg/corfudb/runtime/object/VersionLockedObject.java 89.67% <0%> (+1.63%) ⬆️
...org/corfudb/runtime/view/LayoutManagementView.java 52.34% <0%> (+2.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b8cfb8...3ee118d. Read the comment docs.

@no2chem no2chem merged commit 87cc9e9 into master Dec 12, 2017
@Maithem Maithem deleted the TlsUtilsStacktrace branch December 15, 2017 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants