Fix Flaky SequencerServerTest Suite #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3492 +/- ##
============================================
- Coverage 77.66% 77.57% -0.09%
+ Complexity 4950 4946 -4
============================================
Files 472 472
Lines 23621 23622 +1
Branches 2084 2084
============================================
- Hits 18343 18323 -20
- Misses 4253 4272 +19
- Partials 1025 1027 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This patch addresses flakiness in the SequencerServerTest suite. Since the reportSequencerHealth method is executing on a separate thread, its periodic invocation can interfere with the mocked behaviour of other objects unpredictably. This issue is addressed by mocking the health report scheduler, making the tests deterministic.
zfrenette
force-pushed
the
fixFlakySequencerTests
branch
from
f7906fc
to
b207ada
Compare
Maithem
approved these changes
Jan 18, 2023
xnull
approved these changes
Jan 18, 2023
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses flakiness in the SequencerServerTest suite. Since the reportSequencerHealth method is executing on a separate thread, its periodic invocation can interfere with the mocked behaviour of other objects unpredictably. This issue is addressed by mocking the health report scheduler, making the tests deterministic.
Overview
Description:
Why should this be merged:
Related issue(s) (if applicable): #3460 #3487
Checklist (Definition of Done):