Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Packages Upgrade #202

Merged

Conversation

seanzhangkx8
Copy link
Contributor

Description

As numerous key dependency packages, such as numpy and sklearn, have been upgraded and subsequently lost backward compatibility, it is imperative that ConvoKit undergoes an update to ensure compatibility with these dependency package functions. In this pull request, we have updated the versions of dependency packages and pinpointed the functions that require updates.

Identified Errors:

  1. Sklearn changes function name of get_feature_names() to get_feature_names_out()

@seanzhangkx8 seanzhangkx8 merged commit c5b2bd7 into CornellNLP:master Nov 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants