Improve colander schema error message handling #47
Conversation
| @@ -34,14 +34,14 @@ def _validate_fields(location, data): | |||
| request.errors.add(location, attr.name, | |||
| "%s is missing" % attr.name) | |||
| else: | |||
| if not attr.name in data: | |||
| request.validated[attr.name] = attr.missing | |||
There was a problem hiding this comment.
Please do not remove the request.validated[attr.name] = attr.missing, it's part of the API and shound not be changed. Is there any reason why you're removing it?
There was a problem hiding this comment.
From my point of view, the SchemaNode deserialize() method does the same thing in the right way.
"missing" case is matched with deserialized = attr.deserialize(None)
Moreover, deserialize() populate the error message with values.
There was a problem hiding this comment.
Oh, right. Works for me then, sounds a better way to deal with validation errors. Sounds weird to put something missing in "validated" anyway.
Thanks again for the contribution.
|
Thanks for the pull request, looks good to me appart from the minor nitpick I added. |
Improve colander schema error message handling
Colander error message placeholder were not replaced.
Before :
${val} is greater than ${max}After :
5 is greater than 3