Feature/encryption middleware + coverage #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenrikThoroe
requested changes
Jul 22, 2021
lib/core/networking/websockets/middleware/encryption_middleware.dart
Outdated
Show resolved
Hide resolved
lib/core/networking/websockets/middleware/encryption_middleware.dart
Outdated
Show resolved
Hide resolved
lib/core/networking/websockets/middleware/encryption_middleware.dart
Outdated
Show resolved
Hide resolved
lib/core/networking/websockets/middleware/encryption_middleware.dart
Outdated
Show resolved
Hide resolved
test/core/networking/websockets/middleware/encryption_middleware_test.dart
Outdated
Show resolved
Hide resolved
test/core/networking/websockets/middleware/encryption_middleware_test.dart
Show resolved
Hide resolved
test/core/networking/websockets/middleware/encryption_middleware_test.dart
Show resolved
Hide resolved
test/core/networking/websockets/middleware/encryption_middleware_test.dart
Show resolved
Hide resolved
test/core/networking/websockets/middleware/protocol_middleware_test.dart
Outdated
Show resolved
Hide resolved
|
Yes, this is vulnerable to man in the middle. The only way around this is some sort of pre-verification like trusted certificates (used to sign reply). We might include those in a later PR. |
lib/core/networking/websockets/middleware/encryption_middleware.dart
Outdated
Show resolved
Hide resolved
HenrikThoroe
approved these changes
Jul 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a middleware that establishes a secure connection between WebSocket sessions. It also bumps test coverage for
core/networkingto 100%.