Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #414 #448

Merged
merged 2 commits into from Jun 1, 2023
Merged

closes #414 #448

merged 2 commits into from Jun 1, 2023

Conversation

jstet
Copy link
Member

@jstet jstet commented May 31, 2023

No description provided.

@jstet jstet linked an issue May 31, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented May 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
correlaid ⬜️ Ignored (Inspect) Jun 1, 2023 8:41am

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 31, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9cc2550
Status: ✅  Deploy successful!
Preview URL: https://abfa7a33.correlaid.pages.dev
Branch Preview URL: https://414-icons-navigation.correlaid.pages.dev

View logs

@jstet
Copy link
Member Author

jstet commented May 31, 2023

waiting for confirmation via slack

@friep
Copy link
Contributor

friep commented May 31, 2023

Thanks! I like the elements and think that they could be useful on other pages.

Looking at them on my big ass monitor screen, i have two concerns:

  • font: i don't think the font is well readable from an accessibility perspective when it is so small. i know we have been using it on canva for a bit but i feel for this, it is not so well suited (the letters "mush together" even for me).
  • colors: maybe we could think about different colors for the backgrounds of the icons? I think right now it implies too much of a "sequence". in [correltools](https://github.com/CorrelAid/correltools) , there the opportunity to create qualitative palettes:
scales::show_col(correltools::correlaid_pal()(5))

Screenshot 2023-05-31 at 15 37 10

or is this too many different colors? IDK.

@jstet
Copy link
Member Author

jstet commented Jun 1, 2023

@friep i have increased the font spacing, size etc. Does it work better now?

I intentionally used a sequence of colours so it fits to the gradient of the hero etc.

@jstet
Copy link
Member Author

jstet commented Jun 1, 2023

I will merge for now because i edited texts in the cms that are based on this change and this is blocking the build for other changes.

@jstet jstet merged commit 84bb884 into main Jun 1, 2023
4 checks passed
@jstet jstet mentioned this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons Navigation
2 participants