Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: use finalized block as the chain freeze indicator #1928

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Mar 8, 2024

  • core: use finalized block as the chain freeze indicator

  • core/rawdb: use max(finality, head-90k) as chain freezing threshold

  • core/rawdb: fix tests

  • core/rawdb: fix lint

  • core/rawdb: address comments from peter

  • core/rawdb: fix typo

* core: use finalized block as the chain freeze indicator

* core/rawdb: use max(finality, head-90k) as chain freezing threshold

* core/rawdb: fix tests

* core/rawdb: fix lint

* core/rawdb: address comments from peter

* core/rawdb: fix typo
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 46.80851% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 47.18%. Comparing base (4d14da6) to head (51f20d8).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1928      +/-   ##
==========================================
+ Coverage   47.17%   47.18%   +0.01%     
==========================================
  Files         568      568              
  Lines       68812    68823      +11     
==========================================
+ Hits        32462    32476      +14     
+ Misses      33832    33825       -7     
- Partials     2518     2522       +4     
Files Coverage Δ
core/rawdb/database.go 9.67% <0.00%> (+0.12%) ⬆️
core/rawdb/chain_freezer.go 27.93% <47.82%> (+7.20%) ⬆️

... and 10 files with indirect coverage changes

@ucwong ucwong marked this pull request as ready for review March 8, 2024 12:15
@ucwong ucwong merged commit 897782d into master Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants