Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the test coverage of CortexTheseus #551

Merged
merged 27 commits into from
Jul 4, 2020
Merged

Increase the test coverage of CortexTheseus #551

merged 27 commits into from
Jul 4, 2020

Conversation

DhunterAO
Copy link
Contributor

No description provided.

@DhunterAO DhunterAO self-assigned this Jun 5, 2020
@DhunterAO DhunterAO added in progress Something under development or test unit test about unit test labels Jun 5, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020 •
edited by codecov bot

Codecov Report

Merging #551 into master will increase coverage by 1.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
+ Coverage   46.42%   47.76%   +1.34%     
==========================================
  Files         398      404       +6     
  Lines       50715    51594     +879     
==========================================
+ Hits        23546    24646    +1100     
+ Misses      25396    25039     -357     
- Partials     1773     1909     +136
Impacted Files Coverage Δ
core/cvm.go 59.52% <ø> (+59.52%) ⬆️
core/vm/cvm.go 16.03% <ø> (ø)
core/chain_makers.go 52.88% <100.00%> (+52.88%) ⬆️
common/bytes.go 20.20% <0.00%> (-16.17%) ⬇️
trie/sync_bloom.go 60.52% <0.00%> (-5.27%) ⬇️
accounts/keystore/watch.go 91.66% <0.00%> (-4.17%) ⬇️
p2p/rlpx.go 69.40% <0.00%> (-1.70%) ⬇️
trie/proof.go 75.74% <0.00%> (-1.12%) ⬇️
core/tx_pool.go 76.60% <0.00%> (-0.81%) ⬇️
core/state/statedb.go 51.61% <0.00%> (-0.12%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1df733...67bac21. Read the comment docs.

@ucwong ucwong added this to the v1.10.1 milestone Jun 5, 2020
@ucwong ucwong added the enhancement New feature or request label Jun 5, 2020
@ucwong ucwong modified the milestones: 1.10.1, 1.10.2 Jun 20, 2020
@DhunterAO
remove DAO code in chain_makers
e780eb8
@DhunterAO
Merge branch 'master' into unit-test
84b4f25
@DhunterAO
remove PeekNumber field in CVM
b9a09ca
@DhunterAO
fix bugs in Generatechain
5c40f78 
1. Create CuckooFakeForTest in core package, which can avoid the cycle import.
2. Add Quota and QuotaUsed fields into makeHeader function, which is needed in GenerateChain
3. Update Root in Finalize function for CuckooFakeForTest.
@DhunterAO
add bench test
da71e88
@ucwong ucwong linked an issue Jun 30, 2020 that may be closed by this pull request
Add Fake Mode in Cuckoo Consensus for Testing #622
Closed
@ucwong ucwong mentioned this pull request Jul 1, 2020
Open
@DhunterAO
add blockchain test
c63d624 
1. fix the EIP in genesis
2. add supply in genesis
3. convert CuckooFake into ModeFake
@ucwong ucwong requested review from ShadowErii and ucwong July 2, 2020 10:29
@DhunterAO
update for GenerateChain
fd5a363 
1. Add FinalizeWithoutParent and accumulateRewardsWithoutParent to be used in GenerateChain
2. Update the Quota and Supply setting for verification
3. add downloader and tesetchain test
@DhunterAO
Merge branch 'master' into unit-test
afe884f
@DhunterAO
add downloader test
effe249
@DhunterAO
add FinalizeWithoutParent into CuckooFakeForTest
3452703
@DhunterAO
omit NewFakeFailer and add error test
fc58e6a
@DhunterAO
omit unreachable code
84c6f31
This was linked to issues Jul 3, 2020
EIP related bugs #638
Closed
Description of Quota Rules? #645
Closed
@ucwong ucwong modified the milestones: 1.10.3, 1.11.0 Jul 3, 2020
@DhunterAO DhunterAO marked this pull request as ready for review July 4, 2020 01:50
@DhunterAO
Copy link
Contributor Author

I wonder whether this PR is too big to review, so maybe we can review and merge it now and start other PRs for new tests.

@ucwong
Copy link
Member

ucwong commented Jul 4, 2020 •
edited

I wonder whether this PR is too big to review, so maybe we can review and merge it now and start other PRs for new tests.

OK, I will review and run a full sync for testing. You can run to sync full blockchain on the server, too.

@DhunterAO
Copy link
Contributor Author

OK, I'll try to do this

@DhunterAO
Copy link
Contributor Author

Now the node continues importing new chain segment and I find FIRST MILESTONE PASS, so does this mean everything ok? Or I need to wait for this complete?

@ucwong
Copy link
Member

ucwong commented Jul 4, 2020 •
edited

Now the node continues importing new chain segment and I find FIRST MILESTONE PASS, so does this mean everything ok? Or I need to wait for this complete?

It's OK, this log is from torrentfs

ucwong
ucwong approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member

@ucwong ucwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully sync has passed and it looks good to me

@ucwong ucwong merged commit 5ba7202 into master Jul 4, 2020
@DhunterAO DhunterAO deleted the unit-test branch July 4, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ucwong ucwong ucwong approved these changes

@ShadowErii ShadowErii Awaiting requested review from ShadowErii

Assignees

@DhunterAO DhunterAO

Labels
enhancement New feature or request in progress Something under development or test unit test about unit test
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Description of Quota Rules? EIP related bugs Add Fake Mode in Cuckoo Consensus for Testing
3 participants
@DhunterAO @codecov-commenter @ucwong