Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node | node api and default config fix #609

Merged
merged 2 commits into from
Jun 24, 2020
Merged

node | node api and default config fix #609

merged 2 commits into from
Jun 24, 2020

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Jun 24, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #609 into master will increase coverage by 0.18%.
The diff coverage is 15.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage   46.33%   46.52%   +0.18%     
==========================================
  Files         403      403              
  Lines       50863    50804      -59     
==========================================
+ Hits        23568    23637      +69     
+ Misses      25530    25383     -147     
- Partials     1765     1784      +19     
Impacted Files Coverage Δ
node/api.go 4.00% <ø> (+1.61%) ⬆️
node/errors.go 37.50% <ø> (ø)
node/service.go 41.66% <0.00%> (-3.79%) ⬇️
node/defaults.go 23.07% <9.52%> (-8.75%) ⬇️
node/config.go 45.97% <20.58%> (-6.69%) ⬇️
trie/sync_bloom.go 60.52% <0.00%> (-5.27%) ⬇️
p2p/discover/lookup.go 95.23% <0.00%> (-1.91%) ⬇️
p2p/discv5/table.go 60.27% <0.00%> (-1.37%) ⬇️
trie/proof.go 75.37% <0.00%> (-1.12%) ⬇️
core/tx_pool.go 75.66% <0.00%> (-0.94%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e9796f...e166484. Read the comment docs.

@ucwong ucwong merged commit d692a2d into master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant