Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client | filter args before calling #618

Merged
merged 2 commits into from
Jun 29, 2020
Merged

client | filter args before calling #618

merged 2 commits into from
Jun 29, 2020

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Jun 28, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #618 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
- Coverage   46.45%   46.45%   -0.01%     
==========================================
  Files         398      398              
  Lines       50677    50696      +19     
==========================================
+ Hits        23544    23549       +5     
- Misses      25355    25370      +15     
+ Partials     1778     1777       -1     
Impacted Files Coverage Δ
client/ctxc_client.go 0.00% <0.00%> (ø)
client/signer.go 0.00% <ø> (ø)
p2p/discover/table.go 83.01% <0.00%> (-2.52%) ⬇️
p2p/simulations/http.go 69.56% <0.00%> (-0.55%) ⬇️
p2p/server.go 66.98% <0.00%> (ø)
trie/proof.go 75.37% <0.00%> (ø)
rpc/client.go 81.69% <0.00%> (+0.70%) ⬆️
p2p/simulations/network.go 60.64% <0.00%> (+0.71%) ⬆️
p2p/rlpx.go 71.38% <0.00%> (+0.84%) ⬆️
p2p/discover/lookup.go 97.14% <0.00%> (+1.90%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d653fa...e862ede. Read the comment docs.

@ucwong ucwong merged commit 50832b8 into master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant