Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloader mode race #626

Merged
merged 5 commits into from
Jul 1, 2020
Merged

Downloader mode race #626

merged 5 commits into from
Jul 1, 2020

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Jul 1, 2020

No description provided.

@ucwong ucwong changed the title Dev Downloader mod race Jul 1, 2020
@ucwong ucwong changed the title Downloader mod race Downloader mode race Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #626 into master will increase coverage by 0.08%.
The diff coverage is 3.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   46.38%   46.46%   +0.08%     
==========================================
  Files         398      398              
  Lines       50707    50713       +6     
==========================================
+ Hits        23519    23565      +46     
+ Misses      25405    25374      -31     
+ Partials     1783     1774       -9     
Impacted Files Coverage Δ
cmd/cortex/chaincmd.go 0.00% <0.00%> (ø)
ctxc/downloader/downloader.go 0.00% <0.00%> (ø)
ctxc/downloader/modes.go 0.00% <ø> (ø)
ctxc/handler.go 39.51% <100.00%> (ø)
p2p/simulations/mocker.go 33.63% <0.00%> (-1.82%) ⬇️
p2p/discv5/table.go 60.27% <0.00%> (-1.37%) ⬇️
p2p/rlpx.go 70.53% <0.00%> (-0.29%) ⬇️
p2p/server.go 66.98% <0.00%> (ø)
core/tx_pool.go 77.13% <0.00%> (+0.53%) ⬆️
rpc/client.go 81.69% <0.00%> (+0.70%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1466442...92d4f04. Read the comment docs.

@ucwong ucwong merged commit 5b6e986 into master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants