Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep on increasing the test coverage of CortexTheseus #656

Merged
merged 6 commits into from
Jul 7, 2020
Merged

Conversation

ShadowErii
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #656 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   50.82%   50.82%           
=======================================
  Files         405      405           
  Lines       51727    51727           
=======================================
+ Hits        26289    26292    +3     
- Misses      23413    23422    +9     
+ Partials     2025     2013   -12     
Impacted Files Coverage Δ
p2p/discover/table.go 83.01% <0.00%> (-2.52%) ⬇️
p2p/discover/lookup.go 95.23% <0.00%> (-1.91%) ⬇️
whisper/whisperv6/message.go 69.94% <0.00%> (-1.16%) ⬇️
p2p/simulations/mocker.go 34.54% <0.00%> (-0.91%) ⬇️
ctxc/downloader/statesync.go 68.28% <0.00%> (-0.89%) ⬇️
trie/trie.go 83.40% <0.00%> (-0.86%) ⬇️
p2p/rlpx.go 70.53% <0.00%> (-0.85%) ⬇️
p2p/server.go 66.98% <0.00%> (ø)
p2p/simulations/http.go 70.10% <0.00%> (+0.54%) ⬆️
p2p/simulations/network.go 60.64% <0.00%> (+0.71%) ⬆️
... and 4 more

@ShadowErii ShadowErii added in progress Something under development or test unit test about unit test labels Jul 6, 2020
@ucwong ucwong requested review from ucwong and DhunterAO July 6, 2020 07:43
Copy link
Contributor

@DhunterAO DhunterAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ucwong ucwong merged commit a3298d5 into master Jul 7, 2020
@ShadowErii ShadowErii deleted the unit-test branch July 7, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Something under development or test unit test about unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants