add ctxc client test #669
Merged
add ctxc client test #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Check the exitCh before close it. 2. Adjust the Unmarshal function of Supply in Header. 3. It's nonetheless ugly to spin up a blockchain in GenerateChain. Get rid of it.
Codecov Report
@@ Coverage Diff @@
## master #669 +/- ##
==========================================
- Coverage 50.85% 50.84% -0.02%
==========================================
Files 408 408
Lines 51908 51922 +14
==========================================
+ Hits 26399 26400 +1
- Misses 23478 23492 +14
+ Partials 2031 2030 -1
|
ucwong
reviewed
Jul 10, 2020
| @@ -232,7 +232,9 @@ func (cuckoo *Cuckoo) InitOnce() error { | |||
|
|
|||
| // Close closes the exit channel to notify all backend threads exiting. | |||
| func (cuckoo *Cuckoo) Close() error { | |||
| close(cuckoo.exitCh) | |||
| if cuckoo.exitCh != nil { | |||
| close(cuckoo.exitCh) | |||
ucwong
reviewed
Jul 10, 2020
ctxc/api_backend.go
Outdated
| stateDb, err := b.ctxc.BlockChain().StateAt(header.Root) | ||
| fmt.Println("StateAndHeaderByNumber error: ", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.