ctxc/gasprice/gasprice test #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the interface ctxcapi.Backend has too much method,but it seems that most of them are not impact on getting the suggest gas price |
|
Creating a new OracleBackend interface can solve this confluct |
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 50.88% 50.87% -0.01%
==========================================
Files 407 408 +1
Lines 51815 51907 +92
==========================================
+ Hits 26364 26409 +45
- Misses 23427 23466 +39
- Partials 2024 2032 +8
|
ucwong
force-pushed
the
ctxc-test
branch
2 times, most recently
from
cd7f293
to
588f391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test in ctxc