Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signer/rules:use goja instead of otto #685

Merged
merged 6 commits into from Jul 14, 2020
Merged

signer/rules:use goja instead of otto #685

merged 6 commits into from Jul 14, 2020

Conversation

ShadowErii
Copy link
Contributor

it seems that goja is faster than otto, and there maybe some problems in otto:robertkrimen/otto#266

@ucwong
Copy link
Member

ucwong commented Jul 13, 2020

@ucwong ucwong marked this pull request as draft July 13, 2020 10:13
@ucwong ucwong requested a review from DhunterAO July 13, 2020 10:13
@ucwong
Copy link
Member

ucwong commented Jul 13, 2020

@ShadowErii
Copy link
Contributor Author

more about goja: ethereum/go-ethereum#20470

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #685 into master will decrease coverage by 0.16%.
The diff coverage is 12.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
- Coverage   50.83%   50.67%   -0.17%     
==========================================
  Files         408      413       +5     
  Lines       51943    52108     +165     
==========================================
- Hits        26405    26404       -1     
- Misses      23505    23672     +167     
+ Partials     2033     2032       -1     
Impacted Files Coverage Δ
cmd/cortex/cvm_infer_server.go 0.00% <0.00%> (ø)
inference/gen_avaiable_json.go 0.00% <0.00%> (ø)
inference/gen_gas_json.go 0.00% <0.00%> (ø)
inference/gen_ic_json.go 0.00% <0.00%> (ø)
inference/gen_ih_json.go 0.00% <0.00%> (ø)
inference/gen_work_json.go 0.00% <0.00%> (ø)
inference/synapse/remote_infer.go 0.00% <0.00%> (ø)
inference/types.go 0.00% <ø> (ø)
signer/storage/storage.go 0.00% <0.00%> (ø)
signer/rules/rules.go 76.42% <80.64%> (+2.00%) ⬆️
... and 13 more

@ShadowErii ShadowErii marked this pull request as ready for review July 14, 2020 02:04
@ucwong ucwong merged commit 2c5e09b into master Jul 14, 2020
@ShadowErii ShadowErii deleted the otto2goja branch July 17, 2020 09:00
@ucwong ucwong restored the otto2goja branch July 20, 2020 10:51
@ShadowErii ShadowErii deleted the otto2goja branch July 21, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants