Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console,jsre: use goja instead of otto #691

Merged
merged 3 commits into from Jul 20, 2020
Merged

console,jsre: use goja instead of otto #691

merged 3 commits into from Jul 20, 2020

Conversation

ShadowErii
Copy link
Contributor

the otto still has problems in array sort
截屏2020-07-17 下午5 13 02
so try to use goja

@ShadowErii ShadowErii marked this pull request as draft July 17, 2020 10:00
@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #691 into master will decrease coverage by 0.42%.
The diff coverage is 7.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
- Coverage   50.63%   50.20%   -0.43%     
==========================================
  Files         413      417       +4     
  Lines       52112    52656     +544     
==========================================
+ Hits        26386    26438      +52     
- Misses      23691    24178     +487     
- Partials     2035     2040       +5     
Impacted Files Coverage Δ
internal/jsre/jsre.go 63.41% <ø> (ø)
console/bridge.go 4.91% <7.09%> (ø)
p2p/discover/lookup.go 95.23% <0.00%> (-1.91%) ⬇️
core/tx_list.go 90.31% <0.00%> (-1.21%) ⬇️
core/tx_pool.go 76.66% <0.00%> (-0.74%) ⬇️
p2p/rlpx.go 69.40% <0.00%> (-0.57%) ⬇️
ctxc/downloader/queue.go 81.37% <0.00%> (-0.46%) ⬇️
p2p/peer.go 78.99% <0.00%> (ø)
common/chan.go 0.00% <0.00%> (ø)
... and 8 more

@ShadowErii ShadowErii marked this pull request as ready for review July 18, 2020 03:47
@ucwong ucwong requested a review from DhunterAO July 18, 2020 05:44
@ucwong ucwong merged commit a1344f6 into master Jul 20, 2020
@ShadowErii ShadowErii deleted the otto2goja branch July 20, 2020 02:13
@ucwong
Copy link
Member

ucwong commented Jul 20, 2020

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants