RPC:golint fix #714
RPC:golint fix #714
Conversation
|
Which line ？ |
rpc/testservice_test.go
Outdated
| @@ -93,8 +93,8 @@ func (s *testService) Rets() (string, error) { | |||
| } | |||
|
|
|||
| //lint:ignore ST1008 returns error first on purpose. | |||
| func (s *testService) InvalidRets1() (string, error) { | |||
| return "", nil | |||
| func (s *testService) InvalidRets1() (error, string) { | |||
There was a problem hiding this comment.
ignore the ST1008 check here , and then it won't include in the callbacks
There was a problem hiding this comment.
InvalidRets1 is made as wrong format method for testing
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
==========================================
- Coverage 50.14% 49.99% -0.15%
==========================================
Files 421 421
Lines 53533 53385 -148
==========================================
- Hits 26844 26691 -153
- Misses 24609 24620 +11
+ Partials 2080 2074 -6
|
| @@ -30,6 +30,8 @@ import ( | |||
| "time" | |||
| ) | |||
|
|
|||
| type contextKey string | |||
|
|
|||
There was a problem hiding this comment.
Is it necessary to use a cname here
There was a problem hiding this comment.
yes,it's better not to use string as key in the context.withvalue() ,i thought
There was a problem hiding this comment.
It will be better to use name of httpContextKey or rpcContextKey with more meanings than contextKey here .
There was a problem hiding this comment.
ok,
it avoid key collisions by defining a separate type,although may never happen :)
However,i don't get why if i return error last in a method,it will increse the nums the reciever.Types().Method()(including that method),which will cause getting more callbacks