Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rlp: add SplitUint64 #770

Merged
merged 1 commit into from Sep 17, 2020
Merged

rlp: add SplitUint64 #770

merged 1 commit into from Sep 17, 2020

Conversation

vivijj
Copy link

@vivijj vivijj commented Sep 17, 2020

This can be useful when working with raw RLP data. Rules around integers in RLP are too complicated to just use SplitString and decode the resulting byte slice.

This can be useful when working with raw RLP data.
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #770 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   50.45%   50.53%   +0.07%     
==========================================
  Files         410      410              
  Lines       53443    53461      +18     
==========================================
+ Hits        26965    27016      +51     
+ Misses      24421    24379      -42     
- Partials     2057     2066       +9     
Impacted Files Coverage Δ
rlp/raw.go 95.14% <100.00%> (+4.55%) ⬆️
whisper/whisperv6/whisper.go 54.00% <0.00%> (-1.22%) ⬇️
p2p/rlpx.go 69.97% <0.00%> (-1.14%) ⬇️
rpc/handler.go 89.76% <0.00%> (-0.94%) ⬇️
p2p/simulations/mocker.go 34.54% <0.00%> (-0.91%) ⬇️
p2p/simulations/network.go 59.92% <0.00%> (-0.72%) ⬇️
trie/proof.go 76.11% <0.00%> (-0.38%) ⬇️
ctxc/downloader/downloader.go 78.15% <0.00%> (-0.33%) ⬇️
p2p/discover/v5_udp.go 73.31% <0.00%> (+0.46%) ⬆️
p2p/peer.go 79.90% <0.00%> (+0.91%) ⬆️
... and 5 more

@ucwong ucwong merged commit 82d0a8e into master Sep 17, 2020
@wlt-cortex wlt-cortex deleted the dev-s branch January 7, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants