Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows to Travis builds. #145

Closed
IOBYTE opened this issue Sep 16, 2016 · 8 comments
Closed

Add windows to Travis builds. #145

IOBYTE opened this issue Sep 16, 2016 · 8 comments
Assignees
Milestone

Comments

@IOBYTE
Copy link

IOBYTE commented Sep 16, 2016

Could you add a Windows Visual Studio 2015 Update 3 build to Travis? HEAD currently has compile errors in the tests and example on Windows.

You might also want to consider adding a clang build for linux.

@ben-crowhurst
Copy link
Member

Please see issue #81

If you'd like to undertake this work we'd more than happily accept your PR.

@IOBYTE
Copy link
Author

IOBYTE commented Sep 17, 2016

Sorry but I don't know Travis so I can't help you. I hadn't even heard of REST before two weeks ago and now I have to add REST interfaces to a number of C++ apps (both client and server) so learning REST and the whole WEB thing is keeping me busy. We already have an application domain specific control protocol that is much more powerful and much more efficient than HTTP but management thinks REST is more modern so I have to live with that decision.

I'm developing off of HEAD because web sockets is a requirement and HEAD has build issues on Windows right now and I don't want to be reporting issues that would be apparent if there was a Windows Travis build. I'm just trying to get the basics working and I now have a working client and server with a few hand written resources. I have thousands of resources to support the largest of which could be over a megabyte of xml. Web sockets will come after all the resources are done. I have already switched from HEAD to 4.0 and back to HEAD. I could switch back to 4.0 and do the resources and then switch back to HEAD to do the web sockets but it would be nice if I didn't have to.

I wasted a lot of time trying to get the new openssl to build and finally reverted back to the old one. I wasted a lot of time in the debugger and reading your code trying to figure out how things work because there is no documentation or even comments in the examples explaining how and why things work the way they do. I just don't have the time to be dealing with and working around issues with the Windows build. Sorry for the venting but I feel better now.

@IOBYTE
Copy link
Author

IOBYTE commented Sep 19, 2016

Actually AppVeyor https://www.appveyor.com/ is what you use for Windows for CI.

@ben-crowhurst ben-crowhurst added this to the 4.5 milestone Sep 20, 2016
@ben-crowhurst ben-crowhurst self-assigned this Sep 20, 2016
@ben-crowhurst
Copy link
Member

ben-crowhurst commented Sep 20, 2016

Clearly you are under a significant amount of stress. Please note the following.

  • Working off of HEAD is going to be risky until a complete regression is performed.
  • Commercial use of Restbed is subject to a Corvusoft Permissive License requirement.
  • If you're overloaded at work talk to your line manager about the situation.

Wish you all the best.

@ben-crowhurst
Copy link
Member

ben-crowhurst commented Sep 20, 2016

I forgot to mention, have a look at RestQ for the best use of restbed. A large amount of code duplication can be reduced using a ruleset.

@IOBYTE
Copy link
Author

IOBYTE commented Sep 20, 2016

Ben Crowhurst wrote:

I forgot to mention, have a look at RestQ
https://github.com/Corvusoft/restq for the best use of restbed. A
large amount of code duplication can be reduced with the ruleset.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#145 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvDV5hhJfdz_NDPskprGwfXdtIFUseFks5qsGD2gaJpZM4J_ZT_.

I have looked at it but it doesn't support server side events or web
sockets. Web sockets have been discussed but there is no requirement at
this time. That will probably change after testing proves straight HTTP
is too slow. I want to be ready when that happens.

I plan on using something like RAML to define the API and use annotation
to add the server side function calls and parameter information. I'll
then parse the RAML to generate appropriate resources derived from
restbed::Resource with embedded function calls. I have already hand
generated a few resources as proof of concept. RAML also helps generate
code for the C# and java client developers.

@ben-crowhurst
Copy link
Member

Regarding WebSockets improving the speed of communication, HTTP2 support will drastically increase the throughput for your environment. We don't plan on adding this support until 2017 however.

Thank you for introducing me to RAML.

@ben-crowhurst
Copy link
Member

I should mention that schedule can be accelerated with corporate financial backing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants