Correct the string for IPv4 local/remote endpoints #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, odd. I have memories of fixing this issue previously. I'll create a regression test and then merge the PR. Thanks for your work. |
|
OK so yes I do indeed recall fixing this issue. however, I only resolved the fault for IPv6 👎. |
ben-crowhurst
added a commit
that referenced
this pull request
May 7, 2017
fadedreamz
pushed a commit
to fadedreamz/restbed
that referenced
this pull request
Nov 3, 2017
clrusby
pushed a commit
to clrusby/restbed
that referenced
this pull request
Jul 27, 2018
maggu2810
pushed a commit
to maggu2810/restbed
that referenced
this pull request
Mar 14, 2022
Correct the string for IPv4 local/remote endpoints
maggu2810
pushed a commit
to maggu2810/restbed
that referenced
this pull request
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no colon between the IPv4 hostname and port in the string returned by get_local_endpoint and get_remote_endpoint - i.e. the string looks like this 127.0.0.180. This change modifies the code so the string is correctly returned as 127.0.0.1:80.