Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make acknowledgement required in IbcReceiveResponse::new #1649

Closed
webmaster128 opened this issue Mar 26, 2023 · 1 comment · Fixed by #1940
Closed

Make acknowledgement required in IbcReceiveResponse::new #1649

webmaster128 opened this issue Mar 26, 2023 · 1 comment · Fixed by #1940
Milestone

Comments

@webmaster128
Copy link
Member

Creating an IbcReceiveResponse without acknowledgement leads to

failed to execute message; message index: 0: acknowledgement cannot be empty: invalid acknowledgement: invalid request

which makes sense. We should change this pattern:

-    Ok(IbcReceiveResponse::new()
-       .set_ack(ack)
+    Ok(IbcReceiveResponse::new(ack)
         .add_attribute("action", "acknowledge_ibc_query")
         .add_attribute("job_id", job_id)
         .add_submessage(msg))
@webmaster128
Copy link
Member Author

webmaster128 commented Nov 6, 2023

As discussed with @chipshort. Let's keep the optionality separate (implemented in #1892) as this might be a bigger issue. Here we just add the acknowledgement to the IbcReceiveResponse constructor and remove set_ack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant