k256 v0.13.3 causes an error on secp256k1_recover_pubkey_works test

[loloicci]

After executing cargo update on packages/crypto to update k256 to v0.13.3, test secp256k1::tests::secp256k1_recover_pubkey_works fails with

---- secp256k1::tests::secp256k1_recover_pubkey_works stdout ----
thread 'secp256k1::tests::secp256k1_recover_pubkey_works' panicked at packages/crypto/src/secp256k1.rs:355:88:
called `Result::unwrap()` on an `Err` value: GenericErr { msg: "signature error", backtrace: <disabled> }

This error is not caused with k256 v0.13.1.

[webmaster128]

Thanks you. I can reproduce the issue with k256 v0.13.2 and v0.13.3. On it

[webmaster128]

Caused by this change: Reject signatures which aren't low-S normalized (RustCrypto/elliptic-curves#914) (https://github.com/RustCrypto/elliptic-curves/blob/master/k256/CHANGELOG.md#0132-2023-11-15)

[webmaster128]

Thank you for the report. I think we can address this in two steps:

1. Pin version to 0.13.1
2. Figure out if the old behaviour can be restored by a different way of using k256. I asked here, let's see how straight forward that is.

[webmaster128]

I think #2000 (last commit) is a better fix since it avoids the pinning

[webmaster128]

Update: the fix is now in #2014. In #2000 we are back to adding only test vectors without touching the implementation.