Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change filesystem errors to be consistent across operating systems #1406

Merged
merged 4 commits into from Nov 21, 2022

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Aug 30, 2022

This addresses Windows compatibility to make everyone's life easier and reduce the risk of having system-dependent error messages breaking consensus.

This is an alternative to the OS specific checks in #1369

Closes #1369

@webmaster128 webmaster128 requested a review from uint August 30, 2022 14:45
@webmaster128 webmaster128 marked this pull request as draft August 30, 2022 14:45
@webmaster128 webmaster128 marked this pull request as ready for review August 30, 2022 14:59
@webmaster128 webmaster128 added this to the 1.2.0 milestone Sep 19, 2022
Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I don't have a Windows machine to test with, but if we can't get that feedback easily, let's just go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants