Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distribution module query type #1593

Merged
merged 8 commits into from
Jun 28, 2023

Conversation

0xekez
Copy link
Contributor

@0xekez 0xekez commented Jan 23, 2023

This adds a query type for the distribution module. I've linked to the cosmos-sdk protobufs where relevant, though I'd appreciate advice on how best to test this.

Related PR to add SetWithdrawAddress to multi-test: CosmWasm/cw-multi-test#23

@webmaster128
Copy link
Member

Let's schedule this for 1.3 after #1647 is in. Then you have the relevant feature flag in place for the additional query.

@webmaster128 webmaster128 added this to the 1.3.0 milestone Mar 27, 2023
@webmaster128 webmaster128 modified the milestones: 1.4.0, 1.3.0 Jun 19, 2023
@chipshort chipshort changed the base branch from main to release/1.3 June 26, 2023 11:35
@chipshort
Copy link
Collaborator

I rebased this on 1.3 and added a way to mock it.

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just the feature thing and then it would be good to add a note to both

  • CHANGELOG.md
  • docs/CAPABILITIES-BUILT-IN.md

packages/std/src/query/mod.rs Outdated Show resolved Hide resolved
packages/std/src/query/mod.rs Outdated Show resolved Hide resolved
packages/std/src/query/mod.rs Outdated Show resolved Hide resolved
packages/std/src/testing/mock.rs Outdated Show resolved Hide resolved
packages/std/src/testing/mock.rs Outdated Show resolved Hide resolved
packages/std/src/testing/mock.rs Outdated Show resolved Hide resolved
packages/std/src/testing/mod.rs Outdated Show resolved Hide resolved
packages/std/src/traits.rs Outdated Show resolved Hide resolved
packages/std/src/traits.rs Outdated Show resolved Hide resolved
packages/std/src/query/mod.rs Outdated Show resolved Hide resolved
chipshort and others added 2 commits June 27, 2023 16:56
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
packages/std/src/testing/mock.rs Outdated Show resolved Hide resolved
packages/std/src/testing/mock.rs Show resolved Hide resolved
@chipshort chipshort mentioned this pull request Jun 28, 2023
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@webmaster128 webmaster128 merged commit 732710a into CosmWasm:release/1.3 Jun 28, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants