Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QueryRequest::Grpc #1973

Merged
merged 15 commits into from
Dec 21, 2023
Merged

Add QueryRequest::Grpc #1973

merged 15 commits into from
Dec 21, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1966

Do we also want to remove / deprecate the Stargate query? Only on the contract side ofc, since we need to continue supporting it in wasmd for 1.x compatibility.

packages/std/src/query/mod.rs Outdated Show resolved Hide resolved
packages/std/src/query/mod.rs Outdated Show resolved Hide resolved
packages/std/src/query/mod.rs Show resolved Hide resolved
packages/std/src/query/mod.rs Outdated Show resolved Hide resolved
@webmaster128
Copy link
Member

Do we also want to remove / deprecate the Stargate query? Only on the contract side ofc, since we need to continue supporting it in wasmd for 1.x compatibility.

Let's deprecate it. The migration is not fully trivial since the contract needs to change the decoding from JSON to protobuf. It's a bit nicer to give people time for that.

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could get a sentence or two in MIGRATING.md, especially highlighting the return data format being binary (for real this time 🤞)

@chipshort chipshort merged commit b14e902 into main Dec 21, 2023
28 of 29 checks passed
@chipshort chipshort deleted the 1966-grpc-query branch December 21, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add QueryRequest::Grpc
2 participants