Validate royalty percentage when minting cw2981 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JakeHartnell @shanev @larry0x Please check this PR. |
shanev
approved these changes
Feb 18, 2023
larry0x
reviewed
Feb 18, 2023
larry0x
force-pushed
the
cw2981-validate
branch
from
57981ff
to
db45da1
Compare
|
@larry0x Can we go? |
larry0x
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
At the moment, there is no validation of
royalty_percentagewhen minting new token incw2981-royalties.As percentage over 100% is mostly nonsensical in the context of royalty, it should be checked to prevent potential errors.
For example, a marketplace contract can mistakenly send their own tokens instead of the buyer's because royalty amount will be larger than the price.
=> validate
royalty_percentageto be smaller than equal to 100.