Update cw-plus packages to 0.15.0 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh great, cw-nfts may be one of the first one to update. Cutting edge. 😄 Looking forward to this. (It provides much better schemas and will make ts-codegen happy) |
|
Going to need a rebase. 😂 |
|
You just did a big merge? |
ueco-jb
force-pushed
the
update-cw-plus-0-15-0
branch
from
c37720a
to
dd5e0cc
Compare
ueco-jb
force-pushed
the
update-cw-plus-0-15-0
branch
from
52de28d
to
a1325ee
Compare
ueco-jb
force-pushed
the
update-cw-plus-0-15-0
branch
from
509db67
to
389ca62
Compare
ethanfrey
previously approved these changes
Sep 15, 2022
There was a problem hiding this comment.
What I see looks good.
What I don't see are the changes to schema.rs and moving them to the bin directory and such. I guess the movement is optional, but I think a big part of the upgrade is also using these unified schema output (the new format from Tom).
I am happy to approve and merge this as is. But I would wait until those schema.rs files are modified to tag the repo and make a v0.15 release
| @@ -76,7 +76,8 @@ | |||
| ], | |||
| "properties": { | |||
| "never": { | |||
| "type": "object" | |||
| "type": "object", | |||
| "additionalProperties": false | |||
ueco-jb
force-pushed
the
update-cw-plus-0-15-0
branch
from
5eec9bd
to
ccb105d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.