Migrate to entry_point macro #249
Conversation
There was a problem hiding this comment.
Please don't use the plain #[entry_point] decorator, but rather the library feature flag version. I actually asked Simon to make that the default functionality (disable on library flag), but he thought that was putting too much app-specific logic in cosmwasm base.
If you find the current status too annoying, please look at the original cosmwasm PR; CosmWasm/cosmwasm#701 (comment) and re-open this issue. I just accepted using this larger macro heading everywhere.
It's OK with me. Maybe the macro can be written in a way that has this check inside? (just curious) |
|
Will create a new branch to migrate cw-plus to Rust 0.51.0, as there are a number of linting issues to deal with. |
maurolacy
force-pushed
the
use-entry_point-macro
branch
from
190d906
to
f124791
Compare
Of course there is, the macro could also emit nothing if the "library" feature flag was set. Simon was worried that we would then be adding "magic" feature flag support into the macros, and said to do that in this repo. I see his point (make it explicit) and your point (make it easy) |
Sounds good. So, you will do that first and then rebase this on it? I will approve it, so as soon as CI passes, I am happy. |
|
This was caused by the Changed it so we can merge this independently of the Rust 1.51.0 migration (thanks @ethanfrey). |
| @@ -834,7 +834,7 @@ jobs: | |||
| # Uses --debug for compilation speed | |||
| # FIXME: Change when `check_contract` (part of `cosmwasm-0.14.0`) is published | |||
| #command: cargo install --debug --features iterator --example check_contract -- cosmwasm-vm | |||
| command: cargo install --debug --features iterator --git https://github.com/CosmWasm/cosmwasm --branch=main --example check_contract -- cosmwasm-vm | |||
| command: cargo install --debug --features iterator --git https://github.com/CosmWasm/cosmwasm --tag=v0.14.0-beta1 --example check_contract -- cosmwasm-vm | |||
Closes #230.