Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cw721 token indexes refactor #342

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Cw721 token indexes refactor #342

merged 4 commits into from
Jul 22, 2021

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Jul 22, 2021 •
edited

An addendum to #327 / #340, improving the cw721 tokens by owner index, and updating the docs.

@maurolacy maurolacy requested a review from ethanfrey July 22, 2021 08:04
ethanfrey
ethanfrey approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good. And by using Addr rather than &Addr, you avoid the lifetime issue.

Reviewing it, I realized some of the implied types are confusing and would be great to make explicit. Otherwise, good to merge

contracts/cw721-base/src/state.rs Outdated Show resolved Hide resolved
ethanfrey
ethanfrey approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, makes it a lot clearer.

@maurolacy maurolacy merged commit 61def6e into main Jul 22, 2021
@maurolacy maurolacy deleted the cw721-token-indexes-refactor branch July 22, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maurolacy @ethanfrey