Added implementation of timestamp key #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
approved these changes
Sep 17, 2021
maurolacy
suggested changes
Sep 17, 2021
ethanfrey
reviewed
Sep 19, 2021
| } | ||
| } | ||
|
|
||
| impl From<Timestamp> for TimestampKey { |
ethanfrey
reviewed
Sep 20, 2021
| @@ -250,7 +250,8 @@ impl<T: Endian> From<T> for IntKey<T> { | |||
|
|
|||
| impl<T: Endian> From<Vec<u8>> for IntKey<T> { | |||
| fn from(wrap: Vec<u8>) -> Self { | |||
| // TODO: assert proper length | |||
| // TODO: Consider properly handling case, when `wrap` has length not conforming for the | |||
There was a problem hiding this comment.
Fair enough. Let's do look at TryFrom at some point...
There was a problem hiding this comment.
Solution here is in fact not to implement From, and implement TryFrom instead. That's what Rust std does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #419