workshop subkey PR #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
whalelephant
commented
Aug 26, 2020
whalelephant
commented
- add test for contract name check
- use whitelist init before set_contract_version to reset version on contract
|
|
ethanfrey
approved these changes
Aug 26, 2020
| @@ -344,6 +348,42 @@ mod tests { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| #[test] | |||
| fn get_contract_version_works() { | |||
There was a problem hiding this comment.
Thanks for the testcase. This could be a bit shorter (simple init), but this works as well.
| set_contract_version(&mut deps.storage, &version)?; | ||
| whitelist_init(deps, env, msg) | ||
| let result = whitelist_init(deps, env, msg); | ||
| if result.is_ok() { |
There was a problem hiding this comment.
Nice one, only set on success.
I guess
let result = whitelist_init(deps, env, msg)?;
set_contract_version(&mut deps.storage, &version)?;
Ok(result);would be the same, but this works as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.