Allowances per spender #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
force-pushed
the
756-allowances-per-spender
branch
from
f694456
to
c44646a
Compare
maurolacy
added
the
breaking-state
added 12 commits
July 25, 2022 11:51
maurolacy
force-pushed
the
756-allowances-per-spender
branch
from
c44646a
to
9723ae3
Compare
ueco-jb
approved these changes
Jul 26, 2022
Co-authored-by: Jakub Bogucki <jakub@confio.gmbh>
maurolacy
force-pushed
the
756-allowances-per-spender
branch
from
cd6f976
to
03fdf6b
Compare
maurolacy
removed
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #756.
Opted for a non-api-breaking (i.e. backwards compatible) implementation. This just add a new
AllSpenderAllowancesquery, and keeps all the rest the same.TODO:
Add migration step to populate the. (done)ALLOWANCE_SPENDERmapAdd migration test. (already done)