WIP: Feedback needed - serde[(flatten)] #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
reviewed
Sep 11, 2020
| @@ -27,8 +27,10 @@ pub fn query_all_allowances<S: Storage, A: Api, Q: Querier>( | |||
| let (k, v) = item?; | |||
| Ok(AllowanceInfo { | |||
| spender: api.human_address(&CanonicalAddr::from(k))?, | |||
| allowance: v.allowance, | |||
| expires: v.expires, | |||
| allowance_response: AllowanceResponse { | |||
There was a problem hiding this comment.
Can't we just do allowance_response: v?
Much less verbose and helps make use of flatten
| } | ||
|
|
||
| #[test] | ||
| fn it_should_make_correct_schema() { |
There was a problem hiding this comment.
Oh, this is a very interesting idea.
What I would do would be to define the old AllowanceInfo type for tests and generate json schema for the old and new AllowanceInfo (with and without flatten) and you could compare those two schemas (asset equal)
| mod test { | ||
| use super::*; | ||
| use cosmwasm_schema::schema_for; | ||
| use serde_json; |
There was a problem hiding this comment.
Note we use a custom json serde lib for cosmwasm_std.
You can import cosmwasm_std::to_vec to use that. It would be good to ensure our custom lib supports flatten as well as the standard one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is ref to #57
allowance_responsewhich is helpful for maintainers but probably not so for the users.I think it will be nicer to maintain "extended" structs by using flatten, this assumes we can reuse the basic structs many times. However, it is more verbose when developers have to use "extended" structs.