Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #853

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Update dependencies #853

merged 2 commits into from
Dec 16, 2022

Conversation

apollo-sturdy
Copy link
Contributor

@apollo-sturdy apollo-sturdy commented Dec 16, 2022

Updates the following dependencies:

cw-utils 0.16.0 -> 1.0.1
cw-storage-plus 0.16.0 -> 1.0.1
cw-multi-test 0.16.0 -> 0.16.1

I chose here to use the lowest (but >=1 where available) compatible versions of each so that we can run with -Z minimal-versions.

Please let me know if I should also bump the patch version of each package in this repo or if you have CI or something else that handles this. Also if I should bump the patch version of cw1 which was not modified in this PR.

cw1 = { path = "../../packages/cw1", version = "1.0.0" }
cw2 = { path = "../../packages/cw2", version = "1.0.0" }
cw1-whitelist = { path = "../cw1-whitelist", version = "1.0.0", features = ["library"] }
cosmwasm-std = { version = "1.1.0", features = ["staking"] }
cw-storage-plus = "0.16.0"
cw-storage-plus = "1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use 1.0.1 here as well since 1.0.0 is known to be broken for Wasm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm strange. For some reason the first time I tried building with -Z minimal-versions it worked, but now that I tried again it does indeed fail because cw-storage-plus 1.0.0 is selected. I must have missed something the first time. Will change to 1.0.1. Could be a good idea to also yank 1.0.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you use -Z minimal-versions you need to remove the lockfile fist. Otherwise the version from the lockfile is used.

Could be a good idea to also yank 1.0.0.

This would not have helped here. A version that is in a lockfile already will still be used when yanked.

@webmaster128
Copy link
Member

Thanks you for this PR. Good stuff.

@apollo-sturdy
Copy link
Contributor Author

apollo-sturdy commented Dec 16, 2022

@webmaster128 Bumped cw-storage-plus 1.0.1. Please let me know if I should bump cw-plus package versions or if you will handle that.

@webmaster128
Copy link
Member

Please let me know if I should bump cw-plus package versions or if you will handle that.

@ueco-jb will take care of release and CHANGELOG updates

@ueco-jb ueco-jb merged commit aec2b32 into CosmWasm:main Dec 16, 2022
@apollo-sturdy apollo-sturdy deleted the dev/update-deps branch December 16, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants