Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move 'controllers' and 'cw2' to 'cw-minus' #894

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

kulikthebird
Copy link
Contributor

@kulikthebird kulikthebird commented Feb 5, 2024

Two packages are removed from this repository: cw2 and controllers. Their code is moved to cw-minus by this PR: CosmWasm/cw-minus#26.

Code coverage check was temporarily disabled for the purpose of moving the code. The PR itself does not modify the actual code coverage of any crate.

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2024

CLA assistant check
All committers have signed the CLA.

@kulikthebird kulikthebird force-pushed the move_packages_to_cw_minus branch 3 times, most recently from c4a6409 to 0f7e268 Compare February 7, 2024 13:07
@kulikthebird kulikthebird marked this pull request as ready for review February 7, 2024 14:04
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start.
We should update the README, removing cw2 and cw-controllers there and adding a note about them being moved to cw-minus.
Also, the scripts/publish.sh needs updating

@kulikthebird
Copy link
Contributor Author

Nice start. We should update the README, removing cw2 and cw-controllers there and adding a note about them being moved to cw-minus. Also, the scripts/publish.sh needs updating

Good point, I've just pushed some new commits that address that.

Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulikthebird kulikthebird merged commit f40c2c0 into main Feb 15, 2024
20 of 21 checks passed
@kulikthebird kulikthebird deleted the move_packages_to_cw_minus branch February 15, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants